Sink CodeInfo transformation into transform_result_for_cache
#56897
Conversation
Several downstream consumers want to cache IRCode rather than CodeInfo. Right now they need to override both `finish!` and `transform_result_for_cache`. With this change, only overriding the latter should be sufficient. As a nice bonus, we can avoid doing the work of converting to CodeInfo for interpreters that don't cache at all such as the REPL interpreter.
|
Yes, the code path that goes through finish! twice (although I'm not sure why that happens - possibly a bug?) takes the |
Somewhat of an implementation defect, though one needed to ensure the soundness of the caller mode currently. This is the reason for #56880 which deletes that call, so we could likely just merge that PR first. I think it will have some superficial conflicts with this PR, but nothing significant and VSCode merge tool might be able to figure it out. (the tests on that PR are hitting a different bug in Windows, apparently by changing the probability of encountering it on that particular test for the specific issue, so that PR is almost ready to merge, but I need some time to fix the other bug) |
Several downstream consumers want to cache IRCode rather than CodeInfo. Right now they need to override both
finish!andtransform_result_for_cache. With this change, only overriding the latter should be sufficient. As a nice bonus, we can avoid doing the work of converting to CodeInfo for interpreters that don't cache at all such as the REPL interpreter.