Streamline ci.yml (#234)

JuliaLinearAlgebra · Jun 27, 2024 · c7a3c56 · c7a3c56
1 parent 8c1e9b9
commit c7a3c56
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,33 +6,41 @@ on:
       - master
   pull_request:
 
+permissions:
+  actions: write
+  contents: read
+
 jobs:
   test:
     name: Julia ${{ matrix.version }} - ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     continue-on-error: ${{ matrix.version == 'nightly' }}
     strategy:
-      fail-fast: false
       matrix:
         version:
           - '1.6'
           - '1'
           - 'nightly'
         os:
           - ubuntu-latest
-          - macOS-latest
-          - windows-latest
+        include:
+          - os: windows-latest
+            version: '1'
+          - os: macOS-latest
+            version: '1'
     steps:
       - uses: actions/checkout@v4
-      - uses: julia-actions/setup-julia@latest
+      - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.version }}
       - uses: julia-actions/cache@v2
-      - uses: julia-actions/julia-buildpkg@latest
-      - uses: julia-actions/julia-runtest@latest
+      - uses: julia-actions/julia-buildpkg@v1
+      - uses: julia-actions/julia-runtest@v1
       - uses: julia-actions/julia-processcoverage@v1
+        if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }}
       - uses: codecov/codecov-action@v4
         if: ${{ matrix.version == '1' && matrix.os == 'ubuntu-latest' }}
         with:
-          token: ${{ secrets.CODECOV_TOKEN }}
           file: lcov.info
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/test/trace.jl b/test/trace.jl
@@ -13,7 +13,7 @@ using LinearMaps, LinearAlgebra, Test
     @test tr(LinearMap{Int}(cumsum!, 10)) == 10
     @test tr(2LinearMap{Int}(cumsum!, 10)) == 20
     A = randn(3, 5); B = copy(transpose(A))
-    @test tr(A ⊗ B) == tr(kron(A, B))
+    @test tr(A ⊗ B) ≈ tr(kron(A, B))
     @test tr(A ⊗ B ⊗ A ⊗ B) ≈ tr(kron(A, B, A, B))
     A = randn(5, 5); B = copy(transpose(A))
     @test tr(A ⊗ B) ≈ tr(kron(A, B))