Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to remove invalidations #421

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Conversation

jverzani
Copy link
Member

@jverzani jverzani commented Jun 3, 2022

Another attempt to close issue #403

  • removed spurious module name from abstract type with PnPolynomial constructor
  • relaxed signature of any to avoid base method which defined method for ismissing.

fingers crossed

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #421 (016b873) into master (d0cd9d3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          23       23           
  Lines        2798     2798           
=======================================
  Hits         2342     2342           
  Misses        456      456           
Impacted Files Coverage Δ
src/polynomials/pi_n_polynomial.jl 77.77% <ø> (ø)
src/common.jl 89.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0cd9d3...016b873. Read the comment docs.

@jverzani jverzani merged commit 8116678 into JuliaMath:master Jun 3, 2022
@jverzani jverzani deleted the issue_403d branch June 3, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant