Add Makie.jl recipes #123
Add Makie.jl recipes #123
Conversation
|
So, this commit changes to I will check if it is possible to somehow achieve that. |
|
@giordano is there anything preventing this from being merged? This feature would be really nice to have while working with Makie.jl + Measurements.jl. |
|
Making tests pass would be the very first thing. I'll never merge a PR with failing tests. |
| Makie.convert_arguments(P::Type{<:Band}, x::AbstractVector{<:Measurement}, y::AbstractVector{<:Measurement}) = | ||
| convert_arguments(P, value.(x), value.(y) - uncertainty.(y), value.(y) + uncertainty.(y)) | ||
| Makie.convert_arguments(P::Type{<:Band}, x::AbstractVector{<:Real}, y::AbstractVector{<:Measurement}) = | ||
| convert_arguments(P, x, value.(y) - uncertainty.(y), value.(y) + uncertainty.(y)) |
There was a problem hiding this comment.
Missing new line
| convert_arguments(P, x, value.(y) - uncertainty.(y), value.(y) + uncertainty.(y)) | |
| convert_arguments(P, x, value.(y) - uncertainty.(y), value.(y) + uncertainty.(y)) | |
| @@ -17,30 +17,32 @@ | |||
|
|
|||
| using RecipesBase | |||
|
|
|||
| @recipe function f(y::AbstractArray{<:Measurement}) | |||
There was a problem hiding this comment.
Why was this file changed at all?
| @@ -67,7 +67,8 @@ easy-to-use calculator. | |||
| measurements with their physical units, perform numerical integration | |||
| with [`QuadGK.jl`](https://github.com/JuliaMath/QuadGK.jl), numerical and | |||
| automatic differentiation, and much more. | |||
| * Integration with [`Plots.jl`](https://github.com/JuliaPlots/Plots.jl). | |||
| * Integration with [`Plots.jl`](https://github.com/JuliaPlots/Plots.jl) and | |||
There was a problem hiding this comment.
Perhaps you'd want to mention this in the documentation as well: https://github.com/JuliaPhysics/Measurements.jl/blob/daa1ad282a02d945a1f6c69a8198998aa4b63002/docs/src/index.md#features-list
| @@ -126,4 +126,8 @@ include("show.jl") | |||
| include("parsing.jl") | |||
| include("plot-recipes.jl") | |||
|
|
|||
| function __init__() | |||
There was a problem hiding this comment.
There's already an __init__ function.
Oh, didn't notice that. Sorry. |
|
I think this would be better implemented as a package extension: #133. |
|
Closing in favour of #145 |
Adds in the recipes for Makie.jl from #95.