Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deploying together with Franklin easier #127

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vchuravy
Copy link

This changes the export folder structure to be notebook_name/index.html allowing franklin to just ingest that folder structure.
Probably want this to be configurable.

https://github.com/vchuravy/vchuravy.github.io/blob/c6e13351c86f5d1717d3c864d7cda92b022d9186/.github/workflows/Deploy.yml#L33

I then use the generated json to generate a talks page https://github.com/vchuravy/vchuravy.github.io/blob/c6e13351c86f5d1717d3c864d7cda92b022d9186/utils.jl#L143

x-ref: tlienart/Franklin.jl#813

@fonsp
Copy link
Member

fonsp commented Oct 18, 2023

Happy to see that you got it to work and that the json was useful!

The change from notebook.html to notebook/index.html will be breaking URLs so I'm not sure we can do that... But in https://github.com/JuliaPluto/PlutoPages.jl (the successor to the site-generation part of PlutoSliderServer) we also generate notebook/index.html instead of notebook.html!

We also want to make PlutoSliderServer more modular, which might also help with Franklin integration. @pankgeorg can you link to the miro board?

@vchuravy
Copy link
Author

I will excitedly wait for PlutoPages then. I think my biggest ask would be how to integrate it seemlessly into a Franklin webpage by applying header/footer

@pankgeorg
Copy link
Member

I will excitedly wait for PlutoPages then. I think my biggest ask would be how to integrate it seemlessly into a Franklin webpage by applying header/footer

We are planning a small refactor that will expose the various parts more easily: here is the board @fonsp mentioned https://miro.com/app/board/uXjVM1k5dns=/?moveToWidget=3458764561295045806&cot=14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants