Skip to content

Commit

Permalink
disable auto-scrolling ToC because it interferes with smoothscroll be…
Browse files Browse the repository at this point in the history
…haviour

like clicking on Pluto's progress bar to jump to the currently running cell

This smoothscroll gets cancelled by the scroll event that we trigger with the toc
  • Loading branch information
fonsp committed Sep 22, 2022
1 parent e9f8e13 commit fbcd8dc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PlutoUI"
uuid = "7f904dfe-b85e-4ff6-b463-dae2292396a8"
authors = ["Fons van der Plas <[email protected]>"]
version = "0.7.42"
version = "0.7.43"

[deps]
AbstractPlutoDingetjes = "6e696c72-6542-2067-7265-42206c756150"
Expand Down
2 changes: 2 additions & 0 deletions src/TableOfContents.jl
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ const intersection_callback = (ixs) => {
currently_highlighted_set.add(div)
/// scroll into view
/*
const toc_height = tocNode.offsetHeight
const div_pos = div.offsetTop
const div_height = div.offsetHeight
Expand All @@ -134,6 +135,7 @@ const intersection_callback = (ixs) => {
} else if(current_scroll > scroll_to_top){
tocNode.scrollTop = scroll_to_top
}
*/
})
}
}
Expand Down

2 comments on commit fbcd8dc

@fonsp
Copy link
Member Author

@fonsp fonsp commented on fbcd8dc Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/68764

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.7.43 -m "<description of version>" fbcd8dc23e2a1c590829634334c9e43637ac6ccc
git push origin v0.7.43

Please sign in to comment.