Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for generator given to Select #213

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KronosTheLate
Copy link

@KronosTheLate KronosTheLate commented Jun 6, 2022

This PR adds a method for select for the first argument of type Generator.
An example is added.

The added method only sometimes played nice when default values were provided. In my testing, I was unable to figure out the reason.
More testing should be done before this is merged to resolve the buggy behaviour when providing default values.

This PR adds a method for select for the first argument of type Generator.
An example is added.

The added method only sometimes played nice when default values were provided. In my testing, I was unable to figure out the reason.
More testing should be done before this is merged to resolve the buggy behaviour when providing default values.

I am not sure how extensive testing is for this package, but testing should be added as
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/KronosTheLate/PlutoUI.jl", rev="add_select_method")
julia> using PlutoUI

Or run this code in your browser: Run with binder

@fonsp fonsp marked this pull request as draft June 6, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant