Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: TrustCAT v0.1.0 #121159

Conversation

JuliaRegistrator
Copy link
Contributor

  • Registering package: TrustCAT
  • Repository: https://github.com/fadihamad94/TrustCAT
  • Created by: @fadihamad94
  • Version: v0.1.0
  • Commit: 6a195fb2785b7260c95257ea4770b9c9faae1d3c
  • Git reference: HEAD
  • Description: This package is the implementation of a simple and practical adaptive trust-region method for finding stationary points of nonconvex functions with L-Lipschitz Hessians and bounded optimality gap.
  • Release notes:
Release notes:

First version of the CAT Solver

UUID: 9b9fad45-5422-4e5f-bb86-c82f9426b7bb
Repo: https://github.com/fadihamad94/TrustCAT.git
Tree: 8e8f4e066a270b9cab95bf09f68d4a6272b07a19

Registrator tree SHA: 191228b6dd8b9d0e2965ae3e705fe54c51dcfee8
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Repo URL does not end with /name.jl.git, where name is the package name
  • I was not able to load the package (i.e. import TrustCAT failed). See the AutoMerge logs for details.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@briochemc
Copy link
Contributor

[noblock]

My 2 cents: It's unclear what "CAT" stands for. If I dig into the papers, I see it stands for "Consistently Adaptive Trust". But then "TrustCAT" stands for "Trust Consistently Adaptive Trust"? Maybe there's a better name for the package? I don't know what that would be, I don't even know what "consistently adaptive" means anyway, but maybe something more informative? Maybe the fact that it's a solver for finding stationary points could be somehow included in the name? Regardless of the package name you chose, if it includes the "CAT" acronym, then it would be good to define that acronym in the ReadMe at least.

@fadihamad94
Copy link

@briochemc Thank you for your comment. We decided to name the package CATrustRegionMethod and we included in the package readme an explanation of the name.
We opened another pull request. Can you please close this pull request.

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Dec 11, 2024
@briochemc
Copy link
Contributor

That sounds better to me. (I'm just a commenter here, I can't close or merge PRs, but I don't think you need to do anything.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants