Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: signals as extern block #571

Merged
merged 2 commits into from
Jun 7, 2023
Merged

cxx-qt-gen: signals as extern block #571

merged 2 commits into from
Jun 7, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

Related to #557

@ahayzen-kdab ahayzen-kdab force-pushed the 557-signals-as-extern-block branch 3 times, most recently from 36566be to 305b2f1 Compare June 2, 2023 16:02
@ahayzen-kdab ahayzen-kdab changed the title WIP: signals as extern block cxx-qt-gen: signals as extern block Jun 2, 2023
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review June 2, 2023 16:02
@ahayzen-kdab
Copy link
Collaborator Author

This doesn't remove the emit wrapper yet (even though it's pointless now). I'll rebase the other branch #556 on top of this one to do the tidy ups

@ahayzen-kdab ahayzen-kdab mentioned this pull request Jun 2, 2023
Merged
@ahayzen-kdab ahayzen-kdab force-pushed the 557-signals-as-extern-block branch 2 times, most recently from 2e41095 to d174e32 Compare June 5, 2023 11:28
@ahayzen-kdab ahayzen-kdab added the 🥳🎉 1.0 This issue is part of stabilization for 1.0 release label Jun 5, 2023
@ahayzen-kdab ahayzen-kdab force-pushed the 557-signals-as-extern-block branch from d174e32 to 24c4b20 Compare June 7, 2023 09:32
LeonMatthesKDAB
LeonMatthesKDAB requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more small things to sort out, but going in the right direction overall

book/src/getting-started/1-qobjects-in-rust.md Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/generator/naming/signals.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/test_inputs/passthrough_and_naming.rs Show resolved Hide resolved
crates/cxx-qt-gen/src/generator/rust/signals.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/parser/cxxqtdata.rs Outdated Show resolved Hide resolved
@ahayzen-kdab
cxx-qt-gen: ensure that attributes are handled correctly for cxx_qt::…
e235c03 
…inherit

Ensure that attributes on the extern block are empty,
otherwise unsafe detection can fail.

Ensure that attributes on the method as passed through,
otherwise doc lines don't work.

Related to KDAB#557
@ahayzen-kdab
cxx-qt-gen: move signals away from an enum to an extern "C++" block
3c51560 
Related to KDAB#557
@ahayzen-kdab ahayzen-kdab force-pushed the 557-signals-as-extern-block branch from 24c4b20 to 3c51560 Compare June 7, 2023 13:06
LeonMatthesKDAB
LeonMatthesKDAB approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahayzen-kdab ahayzen-kdab merged commit 4bedcd2 into KDAB:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees
No one assigned
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @LeonMatthesKDAB