Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: use extern "RustQt" block for inherit and signals #580

Merged
merged 1 commit into from
Jun 9, 2023
Merged

cxx-qt-gen: use extern "RustQt" block for inherit and signals #580

merged 1 commit into from
Jun 9, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #579

Closes #557

@ahayzen-kdab
Copy link
Collaborator Author

Need to update book and check tests etc.

@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review June 8, 2023 09:10
@ahayzen-kdab ahayzen-kdab added the 🥳🎉 1.0 This issue is part of stabilization for 1.0 release label Jun 8, 2023
@ahayzen-kdab ahayzen-kdab mentioned this pull request Jun 8, 2023
Merged
LeonMatthesKDAB
LeonMatthesKDAB approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this change is cleaner that I thought it'd be.

@ahayzen-kdab ahayzen-kdab merged commit bb49c51 into KDAB:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees
No one assigned
Labels
🥳🎉 1.0 This issue is part of stabilization for 1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move #[signal] and #[inherit] to extern "RustQt" block
2 participants
@ahayzen-kdab @LeonMatthesKDAB