Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: use #[qobject] #[A] instead of #[cxx_qt::qobject(A)] #634

Merged
merged 4 commits into from
Jul 28, 2023
Merged

cxx-qt-gen: use #[qobject] #[A] instead of #[cxx_qt::qobject(A)] #634

merged 4 commits into from
Jul 28, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

Related to #555

@ahayzen-kdab ahayzen-kdab force-pushed the 555-split-qobject-attribute branch from 977c2af to 9d3a937 Compare July 27, 2023 16:53
@ahayzen-kdab
Copy link
Collaborator Author

Changed to just #[qobject] for now, later we can potentially assume that all types in an extern "RustQt" block are QObjects, but this was a simpler first step without the debate and tidies up some code :-)

LeonMatthesKDAB
LeonMatthesKDAB reviewed Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use Rust Options methods a bit more extensively to make this more readable.
Otherwise looks awesome though :)

crates/cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved
crates/cxx-qt-gen/src/parser/qobject.rs Outdated Show resolved Hide resolved
@ahayzen-kdab ahayzen-kdab force-pushed the 555-split-qobject-attribute branch from 9d3a937 to 665aef5 Compare July 28, 2023 10:54
LeonMatthesKDAB
LeonMatthesKDAB approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahayzen-kdab ahayzen-kdab merged commit 7c3c97f into KDAB:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @LeonMatthesKDAB