Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: add example of using a signal on an external object #670

Merged
merged 3 commits into from
Nov 17, 2023
Merged

examples: add example of using a signal on an external object #670

merged 3 commits into from
Nov 17, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab commented Aug 24, 2023 •
edited
Loading

Related to #577

Requires #669

Requires #681

@ahayzen-kdab ahayzen-kdab mentioned this pull request Aug 24, 2023
Merged
@ahayzen-kdab ahayzen-kdab force-pushed the 577-example branch 3 times, most recently from 12817aa to e9baac4 Compare October 4, 2023 11:06
@ahayzen-kdab ahayzen-kdab force-pushed the 577-example branch 2 times, most recently from 7134b61 to 49d870e Compare November 15, 2023 20:56
@ahayzen-kdab ahayzen-kdab changed the title WIP: examples: add example of using a signal on an external object examples: add example of using a signal on an external object Nov 15, 2023
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review November 15, 2023 20:59
LeonMatthesKDAB
LeonMatthesKDAB reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good.

I think the example itself doesn't really tell you much unless you view the code with it though.

We should improve the wording a bit to fix this short-term and maybe redo some of the examples in the long term.

examples/qml_features/qml/pages/ExternCxxQtPage.qml Outdated Show resolved Hide resolved
@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) November 17, 2023 10:06
@ahayzen-kdab ahayzen-kdab merged commit 8452e25 into KDAB:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @LeonMatthesKDAB