Add HashSet of flags to ParsedQPoperty for optional getters and setters #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFordTytherington
force-pushed
the
feature-optional-rw
branch
3 times, most recently
from
d895bd3 to
a9fa32e
Compare
BenFordTytherington
force-pushed
the
feature-optional-rw
branch
from
2eec457 to
865d7fe
Compare
There was a problem hiding this comment.
A decent start on the documentation, but it should to be phrased a bit more user-friendly.
The people reading this documentation are doing so because they don't know how certain things work or should be used.
So we need to try and describe features in a way that requires as little prerequisite knowledge as possible.
LeonMatthesKDAB
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
We've planned to implement this feature for a very long time.
Thanks to @BenFordTytherington for finally getting it done 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to specify whether QProperties generate getters or setters