Feature: Post Create, Read 기능 구현 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
mng990
approved these changes
Nov 2, 2024
| e.getMessage(), | ||
| ErrorCode.INTERNAL_SERVER_ERROR.getCode())); | ||
| .status(errorCode.getHttpStatus()) | ||
| .body(ErrorResponse.of(errorCode, message)); |
There was a problem hiding this comment.
에러 메시지에서 Stack trace가 포함되는 걸 다듬어 주셔서 감사합니다!
| import java.util.Arrays; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
|
|
||
| public enum OriginType { | ||
| TEXT("text"), | ||
| VOICE("voice"); |
There was a problem hiding this comment.
채팅 목록 업로드와 기본 텍스트는 타입이 분리되어야 할 듯 싶습니다.
CHAT 타입을 추가할게요.
Suggested change
| VOICE("voice"); | |
| TEXT("text") | |
| VOICE("voice"), | |
| CHAT("chat"); |
| import aimo.backend.domains.post.entity.Post; | ||
|
|
||
| public class PostMapper { | ||
|
|
||
| private final static int PREVIEW_CONTENT_LENGTH = 90; |
There was a problem hiding this comment.
인기글의 UI가 넓어서 다른 글의 PREVIEW와는 다른 값이 설정돼야 할 듯 싶습니다.
인기글은 90개, 다른 글들은 21개로 설정해 놓겠습니다.
| } | ||
|
|
||
| // PostType으로 글 조회 | ||
| public Page<FindPostsByPostTypeResponse> findPostDtosByPostType(Member member, PostType postType, Integer page, Integer size) { |
There was a problem hiding this comment.
컨트롤러에서 서비스로 넘길 때 Entity를 그대로 넘기는 건 위험해 보입니다.
개별 DTO를 만들어서 전달하도록 수정하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현한 것
수정한 점
아쉬운 점