Feature: OAuth 구현(#16) #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
기본 FailureHandler가 위 url로 리다이렉팅 되도록 구현되어 있으므로 직접 구현해서 200응답을 반환하도록 변경하였다.
redirect url 방식으로 토큰을 응답하기에 일반적으로 프론트에서 body정보를 받아올 수 없었다. 따라서 url에 담아 redirect 시키면 프론트의 redirect 된 페이지에서 정보를 받아오게 하였다. 다만 이 방식은 보안에 취약하므로 추후 cookie방식으로 변경할 예정이다.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
구현 사항
아쉬운 점