Search through untracked files for graphql-tag. Don't error out on files that can't be found. #66
Conversation
…les that can't be found.
🦋 Changeset detectedLatest commit: 0c46a05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Looks good to me. I would love it if you could add a touch more commentary, but it's no big deal. Thanks for fixing these things.
My review uses Conventional Comments to add context and set expectations for the comments I am leaving.
| // NOTE(john): We want to include untracked files here so that we can | ||
| // generate types for them. This is useful for when we have a new file | ||
| // that we want to generate types for, but we haven't committed it yet. |
There was a problem hiding this comment.
praise: Thanks for the comment.
src/parser/utils.ts
Outdated
| // NOTE(john): This is a bit of a hack, but it's necessary for when we | ||
| // have a file that doesn't have an extension. This will happen when we | ||
| // delete all of the type files before re-running graphql-flow again. |
There was a problem hiding this comment.
question: What is the side-effect of doing this? Can you elaborate in the comment on why this will "just work"? Or perhaps add a comment in the parse.ts code that explains what an empty string means?
Summary:
This fixes two bugs:
Issue: FEI-5065
Test plan:
I built it and ran it in webapp and it worked as expected.