Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Fix up some more alias resolution in graphql-flow. #70

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jeresig
Copy link
Member

@jeresig jeresig commented Jul 30, 2024

🖍 This is an audit! 🖍

Summary:

Missed some other edge cases from my previous PR, this should fix that!

Issue: FEI-5745

Test plan:

I updated the graphql-flow dep in the static service with a link: and confirmed that this new command works as expected.

@jeresig jeresig self-assigned this Jul 30, 2024
@jeresig jeresig requested a review from a team July 30, 2024 19:28
@jeresig jeresig added the audit label Jul 30, 2024
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: fc0dac6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/graphql-flow Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeresig jeresig merged commit 45f09ef into main Jul 30, 2024
1 check passed
@jeresig jeresig deleted the FEI-5745.2 branch July 30, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant