[SR] Linear System - add screen reader support for Linear System interactive graph #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [SRUX doc](https://khanacademy.atlassian.net/wiki/spaces/LC/pages/3460366348/Linear) still needs a label for the grab handle, but I tried my best in the meantime. - Add a label and describedby for the grab handle. - Add aria-live states for the different interactive elements so they don't override each other. Issue: https://khanacademy.atlassian.net/browse/LEMS-1726 Test plan: `yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/linear.test.tsx` Storybook - http://localhost:6006/iframe.html?id=perseuseditor-widgets-interactive-graph--interactive-graph-linear&viewMode=story - Try all the different slopes and intercepts - Move different elements and confirm that the updated aria-label is what is read out, and none of the other elements override the currently focused one.
…inear System interactive graph
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (193ee2a) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2030If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2030 |
|
Size Change: +484 B (+0.04%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
The parent pull-request (#2025) has been merged into |
catandthemachines
requested changes
Dec 19, 2024
| return ( | ||
| <> | ||
| <g | ||
| aria-label={strings.srLinearSystemGraph} |
There was a problem hiding this comment.
This aria-label is not getting read out when navigating to the whole graph. This is because the whole graph descriptions needs to happen at the mafs-graph.tsx level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add the aria label and descriptions for the full graph and the
interactive elements in the Linear System graph, based on the
SRUX doc.
Issue: https://khanacademy.atlassian.net/browse/LEMS-1727
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/linear-system.test.tsxStorybook
View Storybook publish in the checks below to try it yourself.
Screen.Recording.2024-12-18.at.2.04.53.PM.mov