Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Ray graph - Add screen reader support for Ray interactive graph #2036

Open
wants to merge 4 commits into
base: sr-linear-system
Choose a base branch
from

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Dec 18, 2024

Summary:

Add the aria label and descriptions for the full graph and the
interactive elements in the Linear System graph, based on the
SRUX doc.

Issue: https://khanacademy.atlassian.net/browse/LEMS-1734

Test plan:

yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/ray.test.tsx

Storybook
http://localhost:6006/iframe.html?globals=&args=&id=perseuseditor-widgets-interactive-graph--interactive-graph-ray&viewMode=story

Screen.Recording.2024-12-18.at.3.57.53.PM.mov

@nishasy nishasy self-assigned this Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (f754610) and published it to npm. You
can install it using the tag PR2036.

Example:

yarn add @khanacademy/perseus@PR2036

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2036

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Size Change: +228 B (+0.02%)

Total Size: 1.27 MB

Filename Size Change
packages/perseus/dist/es/index.js 418 kB +81 B (+0.02%)
packages/perseus/dist/es/strings.js 5.22 kB +147 B (+2.9%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.26 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@nishasy nishasy marked this pull request as ready for review December 19, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant