Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit handling for extensions #146

Open
bashbaug opened this issue Sep 2, 2021 · 0 comments · May be fixed by #148
Open

revisit handling for extensions #146

bashbaug opened this issue Sep 2, 2021 · 0 comments · May be fixed by #148

Comments

@bashbaug
Copy link
Contributor

bashbaug commented Sep 2, 2021

Creating this issue in response to a review comment: #140 (review)

We currently have a handful of defines in the C++ bindings for extensions. Are these needed? If not, we can remove the defines to simplify testing (this is preferred)? If so, do we need to add defines for other extensions?
@bashbaug bashbaug mentioned this issue Sep 2, 2021
Merged
alycm added a commit to alycm/OpenCL-CLHPP that referenced this issue Sep 6, 2021
@alycm
Test two additional defines and update descriptions in header
22d29fb 
Newly tested defines:
* `CL_HPP_USE_CL_DEVICE_FISSION` (corrected from `CL_HPP_ENABLE_DEVICE_FISSION`)
* `CL_HPP_USE_CL_IMAGE2D_FROM_BUFFER_KHR`

The `CL_HPP_NO_STD_FOO` defines are not tested, because the header won't build
unless an alternative implementation is provided.  `The CL_HPP_USE_DX_INTEROP`
define is not tested because it does not work on platforms without DirectX
headers.

Issue KhronosGroup#146 could make this irrelevant, but easy to test these defines in the
meantime.
@alycm alycm mentioned this issue Sep 6, 2021
Merged
@bashbaug bashbaug linked a pull request Sep 8, 2021 that will close this issue
Open
bashbaug pushed a commit that referenced this issue Sep 15, 2021
@alycm
Test two additional defines and update descriptions in header (#147)
21a34b0 
Newly tested defines:
* `CL_HPP_USE_CL_DEVICE_FISSION` (corrected from `CL_HPP_ENABLE_DEVICE_FISSION`)
* `CL_HPP_USE_CL_IMAGE2D_FROM_BUFFER_KHR`

The `CL_HPP_NO_STD_FOO` defines are not tested, because the header won't build
unless an alternative implementation is provided.  `The CL_HPP_USE_DX_INTEROP`
define is not tested because it does not work on platforms without DirectX
headers.

Issue #146 could make this irrelevant, but easy to test these defines in the
meantime.
@bashbaug bashbaug mentioned this issue Mar 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove extension defines bashbaug/OpenCL-CLHPP
1 participant
@bashbaug