Test two additional defines and update descriptions in header #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly tested defines: * `CL_HPP_USE_CL_DEVICE_FISSION` (corrected from `CL_HPP_ENABLE_DEVICE_FISSION`) * `CL_HPP_USE_CL_IMAGE2D_FROM_BUFFER_KHR` The `CL_HPP_NO_STD_FOO` defines are not tested, because the header won't build unless an alternative implementation is provided. `The CL_HPP_USE_DX_INTEROP` define is not tested because it does not work on platforms without DirectX headers. Issue KhronosGroup#146 could make this irrelevant, but easy to test these defines in the meantime.
bashbaug
approved these changes
Sep 8, 2021
|
I just created #148 which should make these changes unnecessary, but these changes are straightforward, fix the documentation, and increase test coverage, so it seems like a good idea to merge them anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly tested defines:
CL_HPP_USE_CL_DEVICE_FISSION(corrected fromCL_HPP_ENABLE_DEVICE_FISSION)CL_HPP_USE_CL_IMAGE2D_FROM_BUFFER_KHRThe
CL_HPP_NO_STD_FOOdefines are not tested, because the header won't buildunless an alternative implementation is provided.
The CL_HPP_USE_DX_INTEROPdefine is not tested because it does not work on platforms without DirectX
headers.
Issue #146 could make this irrelevant, but easy to test these defines in the
meantime.