Primary node clarification for VK_EXT_physical_device_drm

The extension hinted that the primary node represents display capabilities as its intended purpose, but the current text let it ambiguous enough that there has been confusion and proposed implementations which expose different devices for the primary node. Add clarification notes to further define the scope of primary node in the context of this extension. Signed-off-by: Erico Nunes <[email protected]>
KhronosGroup · Nov 7, 2024 · 662f8b1 · 662f8b1
1 parent 46e04bb
commit 662f8b1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/appendices/VK_EXT_physical_device_drm.adoc b/appendices/VK_EXT_physical_device_drm.adoc
@@ -25,12 +25,17 @@ Unlike the EGL extension, this extension does not expose a string containing
 the name of the device file and instead exposes device minor numbers.
 
 DRM defines multiple device node types.
-Each physical device may have one primary node and one render node
-associated.
-Physical devices may have no primary node (e.g. if the device does not have
-a display subsystem), may have no render node (e.g. if it is a software
-rendering engine), or may have neither (e.g. if it is a software rendering
-engine without a display subsystem).
+Each physical device can only be associated with a single underlying DRM
+device, which may have one primary node and one render node.
+
+Physical devices may have no primary node (e.g. it is not associated with a
+DRM device) or may have no render node (e.g. if it uses a software rendering
+engine), or may have neither (e.g. if it is a software rendering engine not
+associated with any DRM device).
+
+Note: This extension only returns primary node and render node from the same
+DRM device for a Vulkan physical device. Implementations should not return
+primary node and render node from different DRM devices.
 
 To query DRM properties for a physical device, chain
 slink:VkPhysicalDeviceDrmPropertiesEXT to slink:VkPhysicalDeviceProperties2.
@@ -44,5 +49,9 @@ include::{generated}/interfaces/VK_EXT_physical_device_drm.adoc[]
 
 === Version History
 
+  * Revision 2, 2024-11-07
+  ** Clarification about the meaning of the primary node
+  ** Clarification to not advertise more than one DRM device
+
   * Revision 1, 2021-06-09
   ** First stable revision
diff --git a/xml/vk.xml b/xml/vk.xml
@@ -22497,7 +22497,7 @@ typedef void* <name>MTLSharedEvent_id</name>;
         </extension>
         <extension name="VK_EXT_physical_device_drm" number="354" author="EXT" type="device" contact="Simon Ser @emersion" supported="vulkan" depends="VK_KHR_get_physical_device_properties2,VK_VERSION_1_1">
             <require>
-                <enum value="1"                                             name="VK_EXT_PHYSICAL_DEVICE_DRM_SPEC_VERSION"/>
+                <enum value="2"                                             name="VK_EXT_PHYSICAL_DEVICE_DRM_SPEC_VERSION"/>
                 <enum value="&quot;VK_EXT_physical_device_drm&quot;"        name="VK_EXT_PHYSICAL_DEVICE_DRM_EXTENSION_NAME"/>
 
                 <enum offset="0" extends="VkStructureType" name="VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_DRM_PROPERTIES_EXT"/>