Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTFPotOfCoals added #47

Merged
merged 2 commits into from
Nov 29, 2023
Merged

glTFPotOfCoals added #47

merged 2 commits into from
Nov 29, 2023

Conversation

echadwick-artist
Copy link
Contributor

This asset represents a copper pot using emissive for glowing hot coals, coated with a clearcoat layer on the exterior, and including the glTF and Khronos Group logos.

screenshot_Large

This asset represents a copper pot using emissive for glowing hot coals, coated with a clearcoat layer on the exterior, and including the glTF and Khronos Group logos.
@MarkCallow
Copy link

I am surprised by the use of .jpgs for the normals and orm (both non-color data). However the rendering at the top of this page looks great.

@echadwick-artist
Copy link
Contributor Author

Thanks Mark!

I used glTF Compressor to convert the original PNGs (16mb), and the real-time feedback helped a ton with choosing how much compression and downscaling to use.

This asset is meant for use with the new glTF iOS viewer app, so I wanted to keep the download as small as possible.

We do need to figure out if we want to also include source assets in this repository, like we did with the old glTF Sample Models. That will significantly impact the size of the repo though.

@lexaknyazev
Copy link
Member

The Khronos Logo Usage Guidelines suggest that there should be more clear space around the glTF logo.

@DRx3D
Copy link
Contributor

DRx3D commented Nov 13, 2023

@lexaknyazev : I presume the distance of concern is the space above the logo and below the pot rim. The preferred space is the (vertical size) of "F". The guidelines allow that the "... clear space requirement may be adjusted to the extent necessary to comply with Visual Integrity requirements". The placement and size of the logo do maintain the visual integrity, so (I believe) it is a matter of artistic choice.

@echadwick-artist : Would the size & placement of the logo carry the same weight and convey the same effect if it was made to strictly comply with the clear space guideline?

* Scaled glTF logo to match design requirements.
* Added DGG logo.
* Improved textures.
* Added more screenshots to the readme.
@echadwick-artist
Copy link
Contributor Author

I have resized the glTF logo to match the guidelines, added the DGG logo, and improved various textures.

screenshot_Large
screenshot_Angles

@DRx3D
Copy link
Contributor

DRx3D commented Nov 17, 2023

@echadwick-artist : Please confirm that DGG allows the use of it's logo on 3D models. Most logo usage guidelines do not allow for distortion, which prohibits the use on 3D models. Khronos' guidelines require visual integrity.

@echadwick-artist
Copy link
Contributor Author

I have confirmed, DGG is ok with this use.

@echadwick-artist echadwick-artist merged commit 2a44794 into main Nov 29, 2023
4 checks passed
@emackey emackey deleted the glTFPotOfCoals-asset branch January 5, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants