-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Develop/gltf sample viewer enhancements #342
Conversation
…-viewer-enhancements # Conflicts: # 2.0/model-index.json
…-viewer-enhancements # Conflicts: # 2.0/model-index.json
Seeing a number of 4K textures containing just a solid color here – would it be possible to swap those for a factor? |
Some models seem to have cases where the file name differs from the folder name. Following convention, it is more consistent to match file and folder names. Since SheenChair already exists, it would be better to place it in a different folder. Below are the proposed changes.
|
I transformed the base color and emissive textures to factors and renamed to assets as suggested |
@UX3D-haertl Thank you for the improvement.
|
I experimentally tried the |
The ClearcoatRing materials are all using |
@donmccurdy Thank you for your advice. Results appear to be good. |
The automated validation failed. We would like to get this merged in the next week if everything is clean and good to go. |
@echadwick-wayfair , @emackey : Please make a final review of the models |
@UX3D-haertl : Except for the conflict with model-index.json, is this PR ready to go? |
Yes it is ready from my side |
This PR adds models which were previously used for the sample viewer