This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add AudioSimple asset #360
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Audio Simple | ||
|
|
||
| Simple asset to test the KHR_audio extension. This model contains one global audio emitter and one positional audio emitter. The positional audio emitter is attached to the node with the blue sphere mesh. This sphere is animated around the origin of the scene. | ||
|
|
||
| In a correct implementation of KHR_audio, you should hear the talking audio coming from the blue sphere circling around the origin. You should also hear some ambient audio including tropical birds chirping at a constant 50% gain no matter where your audio listener is in the scene. | ||
|
|
||
| ## Screenshot | ||
|
|
||
|  | ||
|
|
||
| ## License Information | ||
|
|
||
| The model was created by Robert Long (Matrix.org Foundation) | ||
|
|
||
| All audio comes from freesound.org | ||
| - https://freesound.org/people/ZyryTSounds/sounds/222993/ | ||
| - https://freesound.org/people/yottasounds/sounds/232134/ | ||
|
|
||
| All assets are licensed CC0 | ||
|
|
||
| [](http://creativecommons.org/publicdomain/zero/1.0/) | ||
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the file extensions do not match, you probably need to change the extension of the referenced file to
.png.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think the size of
screenshot.pngis bigger than the others. can you change1200x1200to about400x400?This is because
screenshot.pngis also used for list display.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cx20 On the one hand, I agree. On the other hand, it's a bit subtle:
Subjectively, I like such screenshots and their width to be a bit more "regular" and "predictable". For example:
The latter can (unfortunately) only be achieved with some (non-markdown)
<img...>tags. But I think that it looks nicer this way...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It's a detail, but I just brought this up in https://github.com/KhronosGroup/glTF-Sample-Models/issues/362 nevertheless...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the final decision on this? I fixed the file extension, should I still resize the thumbnail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robertlong Thank you for correcting the file extension.
I think it would be nice to have a small image for the thumbnail, but I'm not too particular about it.
BTW, Regarding the screenshot, how about making it a forest rather than the sea?
The reason I think so is because the environmental sounds are the chirping of birds.