Make source property required in texture #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emackey
added
breaking change
|
I think this was intentional so that extensions could supply alternate texture sources...? |
|
I think this thread #1226 has the most context. |
|
Is it a breaking change in practice for existing software? Or is this a spec bug fix? If this is merged, the generated markdown should also be updated. |
|
|
|
Right, thanks @lexaknyazev. That means we can't merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently textures without an image source are valid glTF which leads to errors in some engines (e.g. Babylon.js, Cesium, Three.js).
As it is unspecified how engines should display such 'empty' texures, the specification should probably be modified to prohibit them.
Example:
glTF.zip