-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain why texture.source is not always required #1549
Conversation
Should textures with nor |
Good question. Would there be some future way to supply a texture that didn't place an extension directly on the texture object, but still used a texture object? I don't... think so? Current implementations mostly throw an exception if a source isn't supplied one way or another. |
|
Sure. So I don't think we can tighten the schema-level field requirements on this. Is my description here good enough then, or does it need to change to indicate that engines are free to use default colors or even reject models that don't properly specify a source? (Where "properly" in my mind is either specifying it with the source property, or marking a WebP or DDS type extension under "extensionsRequired"). The WebP extension for example specifically states that it must be placed in |
At least, I'd change "must" -> "may". Otherwise, it sounds like textures without |
Would this make sense? texture.sourceThe index of the image used by this texture. When undefined, it is expected that an extension or other mechanism will supply an alternate texture source. |
@lexaknyazev Is this OK? |
Should we suggest any behavior in case when nor |
How about this: The index of the image used by this texture. When undefined, it is expected that an extension or other mechanism will supply an alternate texture source, otherwise behavior is undefined. |
Updated as we discussed. |
Fixes #1226.