Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added BGA-200 pitch 0.80x0.65 mm for LPDDR4/4X SDRAM. #2437

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

mhrdmhrd
Copy link
Contributor

@mhrdmhrd mhrdmhrd commented Aug 30, 2020

Datasheet: http://www.issi.com/WW/pdf/43-46LQ32256A-AL.pdf

Screenshot:
image

Package dimensions from the data sheet on page 7:
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:


Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

Replaced by the footprint generated by kicad-footprint-generator. Chamfer is only corrected because F.SilkS partially overwrapped a BGA pad.
@mhrdmhrd
Copy link
Contributor Author

mhrdmhrd commented Aug 31, 2020

Thank you for reviewing my PR. I have made the two changes below:

  • Changed the file name to correct the package size embedded in it. (10.0x15.0 -> 10.0x14.5)
  • Replaced by the footprint generated by kicad-footprint-generator. I have only adjusted the chamfer because it partially over wrapped a BGA pad. -> the adjustment has been canceled.

@aris-kimi aris-kimi added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Sep 1, 2020
@cpresser
Copy link
Contributor

cpresser commented Sep 9, 2020

@evanshultz I assigned you since you already took the footprint-generator PR. Un-assign yourself if you are not happy with that.

@evanshultz
Copy link
Collaborator

@mhrdmhrd
Can you please confirm that the script-generated footprint didn't require any dimension adjustments? Your first bullet doesn't apply now?

Did you make any other edits? For example, the description doesn't look like it came directly from the script.

Lastly, see my comments in the script PR.

@mhrdmhrd
Copy link
Contributor Author

@evanshultz
Yes, I have removed all the dimension adjustments that included in the first bullet.
The description had changed in the previous commit, but I have replaced it with script-generated one. So the footprint is exactly same as the one generated by the script now.

Thanks!

@evanshultz evanshultz merged commit 2dcf1b3 into KiCad:master Sep 16, 2020
@evanshultz
Copy link
Collaborator

Thank you!

@mhrdmhrd mhrdmhrd deleted the feature/IS43LQ32256A-062BLI branch September 17, 2020 12:17
@mhrdmhrd
Copy link
Contributor Author

Thank you for your support and merging!

@antoniovazquezblanco antoniovazquezblanco added this to the 6.0.0 milestone Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants