-
Notifications
You must be signed in to change notification settings - Fork 742
Added symbols for TE PE0xxFxx bistable latching relays. #2649
Conversation
Hello @amil109 You have unwanted modifications on this PR (MAX4820 and MAX4821), see https://github.com/KiCad/kicad-symbols/pull/2649/files Can you cleanup before I start the review ? Thanks |
Remove non-needed file with MAX4820 and MAX4821.
Remove non-needed file relating to MAX4820 and MAX4821.
Hi Joel, Sure - I've removed the files, sorry about that! Kind regards, Andrew |
Well, I do not expect you to remove the file. Git diff still not correct I think. See above link. |
Updated to correct movement of G2RL-2-DC5 definition
Updated to remove movement of G2RL-2-DC5
Hi Joel, Sorry - I had misunderstood - I think it should be correct now. Driver_Relay.dcm and Driver_Relay.lib are not related to this pull request, they snuck in there because they are also changed in my library (and I'm not very good with Git yet sorry!). I've updated the Relay.dcm and Relay.lib files to only include the additions I made - I'm honestly not sure why the other relay moved in the library, but it should be sorted now in any case. Cheers, Andrew |
I understood that but they should not be modified in the pull request. I cannot merge a part of the pull request only. The content of the git diff on the pull request should be the EXACT modifications you made. You can recreate again the pull request if you think it will be easier. Joel |
Right - I think I understand now. Sorry for the confusion, and thank you for explaining it! Closing this PR, replaced with #2946 . |
Added symbols for TE PE0xxFxx bistable latching relays.
Based on OMRON G5Q-1 footprint.
https://www.te.com/commerce/DocumentDelivery/DDEController?Action=showdoc&DocId=Data+Sheet%7FPE_bistable%7F0919%7Fpdf%7FEnglish%7FENG_DS_PE_bistable_0919.pdf%7F3-1415390-1
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
KiCad/kicad-footprints#2225