Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Update Murata NXE #2973

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Update Murata NXE #2973

merged 2 commits into from
Sep 16, 2020

Conversation

Werni2A
Copy link
Contributor

@Werni2A Werni2A commented Sep 10, 2020

This was probably the total overkill just to rename a 3d model 🙈

  • Updated footprint name
  • Updated datasheet links

NXE1 Datasheet
NXE2 Datasheet

This is related to:
Symbol PR
Footprint PR
3D package PR
3D generator PR

⚠️ Deprecation warning

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).

We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@repo-lockdown
Copy link

repo-lockdown bot commented Sep 10, 2020

This repository does not accept pull requests at this time, see the README for details.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Sep 16, 2020

Hi @Werni2A , thanks for contributing,

A few comments I have during my review:

  • Datasheet link of "NXE2S0505MC" not changed

Else looks good, no comments on the other PR.

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

Update muRata -> Murata in footprint filter
@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 16, 2020

@myfreescalewebpage good catch. I updated the link and also the muRata to Murata in the footprint filter.

@myfreescalewebpage myfreescalewebpage added Pending footprint Pending footprint acceptance before merging and removed Pending footprint Pending footprint acceptance before merging labels Sep 16, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage myfreescalewebpage merged commit bd08539 into KiCad:master Sep 16, 2020
@Werni2A
Copy link
Contributor Author

Werni2A commented Sep 16, 2020

@myfreescalewebpage Thanks and sorry for all the effort 😅

@Werni2A Werni2A deleted the Update_NXE2 branch September 16, 2020 16:03
@myfreescalewebpage
Copy link
Collaborator

No worries :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library garlic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants