Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny sending and receiving shared media redirects #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raja-grewal
Copy link
Contributor

As per #279 (comment).

Changes

Set sysctl net.ipv4.conf.*.shared_media=0

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@ArrayBolt3
Copy link
Contributor

ArrayBolt3 commented Dec 20, 2024

Seems fine to me, worst-case scenario it makes the network less efficient from my research, and there seems to be a good argument for setting this option.

Edit: Minor nitpick, but there seems to be some extra whitespace (two spaces in a row) in the comments above the actual sysctl option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants