Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experimental/debug.h with many helper macros #24

Merged
merged 4 commits into from
Jun 10, 2020

Conversation

aviallon
Copy link
Member

@aviallon aviallon commented Jun 6, 2020

This is very useful for displaying error/debug messages to the developper.
Has to be merged after #23 for full compatibility.

This is very useful for displaying error/debug messages to the developper.
Copy link

@pixelherodev pixelherodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good overall, though I'd like a few changes as noted.

I really appreciate you doing this, it motivates me to work on this more as well :)

include/experimental/debug.h Outdated Show resolved Hide resolved
include/experimental/debug.h Outdated Show resolved Hide resolved
Copy link

@pixelherodev pixelherodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good now, I think.

include/experimental/debug.h Show resolved Hide resolved
include/experimental/debug.h Show resolved Hide resolved
@pixelherodev pixelherodev merged commit 07b5cac into KnightOS:master Jun 10, 2020
@aviallon aviallon deleted the patch-debug-improvement branch June 10, 2020 22:32
aviallon added a commit to aviallon/libc that referenced this pull request Jun 14, 2020
* Improve experimental/debug.h with many helper macros

This is very useful for displaying error/debug messages to the developper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants