AwsS3 Fix rename method for url not safe source #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nm2107
reviewed
Jan 3, 2020
| $this->filesystem->write('foo', ''); | ||
| $this->filesystem->rename('foo', 'foo%_encode'); | ||
|
|
||
| $this->assertTrue($this->filesystem->has('foo')); |
There was a problem hiding this comment.
shouldn't the original name not be present ?
There was a problem hiding this comment.
You are right 👌
Anyway there is no environment where this tests for S3 are executed?
Update AwsS3Test.php
alexgt9
changed the title
alexgt9
changed the title
Nek-
suggested changes
Oct 7, 2022
| /** | ||
| * @test | ||
| */ | ||
| public function shouldRenameAnObject() |
There was a problem hiding this comment.
This test pass with and without the fix. The test name is also not clear regarding what it fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename method fails when using non url safe chars in the source parameter.
I just url encode the
CopySourceparameter in the API call