Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use default symfony folder structure #473

Merged
merged 2 commits into from
Apr 13, 2024
Merged

feat: use default symfony folder structure #473

merged 2 commits into from
Apr 13, 2024

Conversation

Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Mar 2, 2024 •
edited
Loading

garak
garak requested changes Mar 3, 2024
View reviewed changes
Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make much sense to me unless we completely remove the "Resources" folder.
So, please move the config as well

@Chris53897 Chris53897 changed the title feat: move templates to default symfony folder structure feat: use default symfony folder structure Apr 12, 2024
@Chris53897
Copy link
Contributor Author

@garak I did now moved the config folder, too.

@garak garak merged commit 13426db into KnpLabs:master Apr 13, 2024
9 checks passed
@Chris53897 Chris53897 deleted the feature/move-template-folder branch April 13, 2024 17:53
@stof
Copy link
Collaborator

stof commented Apr 15, 2024

This PR is incomplete as it does not change the bundle class to tell Symfony that the new structure is used, causing #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garak garak garak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chris53897 @stof @garak @Chris8934