-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kic): add upstream TLS verification guide #8201
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c659dde
to
cd90ea5
Compare
3928706
to
9309404
Compare
Probably more related to the CRD move than this but I was missing a bunch of RBAC to some CRDs (.e.g: kongupstreampolicies, konglicences, kongcustomentities, kongvaults, kongconsumergroups) once fixing |
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Show resolved
Hide resolved
One thing I'm unsure here is how we articulate this guide for BackendTLS. Should we just add a last section to this guide: "Configure Kong Gateway to verify the upstream TLS certificate using GatewayAPI BackendTLS"? |
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Show resolved
Hide resolved
Those should all be in place, weird 🤔 . ℹ️ |
a175f36
to
130c695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clear and works well.
My only point of confusion is around the likely connection reuse that would confuse anyone doing things quickly.
However, I'm not sure how we can fix this.
```text | ||
deployment.apps/echo patched | ||
service/echo patched | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: but I was blindly copy pasting and applying. So when I saw this I had to look back and check that I didn't miss a step because the last copy/paste only updates the service.
Might be worth doing either both patches in one block or have the output for each block (I prefer this second option).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, it will be cleaner to have the expected outputs separately: 5d8a855
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Show resolved
Hide resolved
ac0800f
to
fd72900
Compare
ac0800f added the ℹ️ I've created Kong/kubernetes-ingress-controller#6834 to cover the implementation gap between using annotations and |
fd72900
to
25efd42
Compare
26812a7
to
697f576
Compare
643918a
to
523dacf
Compare
Changed annotations to use plural form (following Kong/kubernetes-ingress-controller#6845) in b8e6034 and added navtabs for CA certificates sourced from Secrets for BackendTLSPolicy (as we've decided it will be implemented before releasing KIC 3.4 in Kong/kubernetes-ingress-controller#6834) in 523dacf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @czeslavo, the PR looks good to me apart from a detail: in the prerequisite section of the guide we are installing Gateway API from the standard channel, while BackendTLSPolicies
are in the experimental one. We should update the Gateway API installation section with the proper channel.
Good catch, fixed in 0d93270. |
…-upstream-tls-ca template
0d93270
to
9e49ba5
Compare
app/_src/kubernetes-ingress-controller/guides/security/verify-upstream-tls.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Adds a guide covering upstream TLS verification configuration features added in KIC 3.4.
Part of #8133 (this guide will have to be extended with Gateway API instructions once Kong/kubernetes-ingress-controller#6631 is implemented).
Testing instructions
KIC nightly image has to be used for testing:
Preview link: https://deploy-preview-8201--kongdocs.netlify.app/kubernetes-ingress-controller/unreleased/guides/security/verify-upstream-tls/
Checklist