You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does this enhancement require public documentation?
I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)
Problem Statement
To satisfy the priority specifications of HTTPRoute matches, the translator split HTTPRoute by each hostname and match, and generate one Kong route for each combination of split match. This increases the number of generated Kong routes. Also, it may bring lots of changes to translated Kong configuration when some HTTPRoute changed that cause priorities of multiple matches change.
We should consider how to consolidate these routes and make the translation result still satisfy the priority specification.
Proposed Solution
Assign the same priority to split matches from the same HTTPRoute rule if the priority ties on priority values calculated from attributes(hostname, method, path, header, query, ..,) and relative orders of parent HTTPRoute and rule.
For the split matches from same rule and having the same priority, we translate them into one Kong route when using expression based routes.
Additional information
We can consider to consolidate the Kong routes more by violating the spec of "relative" priorities to break ties when the priorities came from the match attributes are the same. When the priorities calculated from match attributes (hostname, path, method, headers, queries), we assign the same priorities and do not run the tie breaker to sort parent HTTPRoutes and rules.
This could reduce the changes of priorities when HTTPRoutes updated. Currently there are no such conformance test cases to verify the priority from relative orders, but I am not sure if the upstream will add such cases.
Acceptance Criteria
Matches from the same rule with the same priorities calculated from match attributes have the same priority assigned
Matches from the same rule and having the same priories are translated to one Kong route when expression routes enabled
The text was updated successfully, but these errors were encountered:
Is there an existing issue for this?
Does this enhancement require public documentation?
Problem Statement
To satisfy the priority specifications of
HTTPRoute
matches, the translator splitHTTPRoute
by each hostname and match, and generate one Kong route for each combination of split match. This increases the number of generated Kong routes. Also, it may bring lots of changes to translated Kong configuration when someHTTPRoute
changed that cause priorities of multiple matches change.We should consider how to consolidate these routes and make the translation result still satisfy the priority specification.
Proposed Solution
HTTPRoute
rule if the priority ties on priority values calculated from attributes(hostname, method, path, header, query, ..,) and relative orders of parentHTTPRoute
and rule.Additional information
We can consider to consolidate the Kong routes more by violating the spec of "relative" priorities to break ties when the priorities came from the match attributes are the same. When the priorities calculated from match attributes (hostname, path, method, headers, queries), we assign the same priorities and do not run the tie breaker to sort parent
HTTPRoute
s and rules.This could reduce the changes of priorities when
HTTPRoute
s updated. Currently there are no such conformance test cases to verify the priority from relative orders, but I am not sure if the upstream will add such cases.Acceptance Criteria
The text was updated successfully, but these errors were encountered: