Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): combine services across httproutes expression router #6766

Merged

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Dec 4, 2024

What this PR does / why we need it:

Second part of #5801. Generate combined Kong services for rules sharing the same bakends when expression based routes are used.

Which issue this PR fixes:

Fixes #6727

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey added the area/feature New feature or request label Dec 4, 2024
@randmonkey randmonkey added this to the KIC v3.4.x milestone Dec 4, 2024
@randmonkey randmonkey requested a review from a team as a code owner December 4, 2024 07:48
@randmonkey randmonkey force-pushed the feat/combine_services_across_httproutes_expression_router branch from 5a84a0f to 40da52b Compare December 4, 2024 07:51
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (4f6373f) to head (5eb89d1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...al/dataplane/translator/subtranslator/httproute.go 83.3% 4 Missing and 2 partials ⚠️
...ataplane/translator/subtranslator/httproute_atc.go 89.6% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6766     +/-   ##
=======================================
+ Coverage   77.7%   79.0%   +1.2%     
=======================================
  Files        208     208             
  Lines      24833   24766     -67     
=======================================
+ Hits       19314   19579    +265     
+ Misses      4539    4191    -348     
- Partials     980     996     +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey force-pushed the feat/combine_services_across_httproutes_expression_router branch from 40da52b to 34393de Compare December 4, 2024 08:16
@randmonkey randmonkey self-assigned this Dec 4, 2024
@randmonkey randmonkey force-pushed the feat/combine_services_across_httproutes_expression_router branch 2 times, most recently from 2c6b80e to 91a0f1f Compare December 4, 2024 12:35
@randmonkey randmonkey enabled auto-merge (squash) December 4, 2024 12:36
@randmonkey randmonkey force-pushed the feat/combine_services_across_httproutes_expression_router branch 4 times, most recently from 4a811e0 to df6e670 Compare December 10, 2024 02:31
@randmonkey randmonkey force-pushed the feat/combine_services_across_httproutes_expression_router branch from df6e670 to c29f86c Compare December 11, 2024 03:47
@randmonkey randmonkey force-pushed the feat/combine_services_across_httproutes_expression_router branch from c29f86c to 5eb89d1 Compare December 11, 2024 05:35
@randmonkey randmonkey requested a review from pmalek December 11, 2024 05:55
@randmonkey randmonkey merged commit 63de014 into main Dec 11, 2024
41 checks passed
@randmonkey randmonkey deleted the feat/combine_services_across_httproutes_expression_router branch December 11, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine Gateway services from different HTTPRoutes for expression router
2 participants