-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translator): combine services across httproutes expression router #6766
Merged
randmonkey
merged 3 commits into
main
from
feat/combine_services_across_httproutes_expression_router
Dec 11, 2024
Merged
feat(translator): combine services across httproutes expression router #6766
randmonkey
merged 3 commits into
main
from
feat/combine_services_across_httproutes_expression_router
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
randmonkey
force-pushed
the
feat/combine_services_across_httproutes_expression_router
branch
from
December 4, 2024 07:51
5a84a0f
to
40da52b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6766 +/- ##
=======================================
+ Coverage 77.7% 79.0% +1.2%
=======================================
Files 208 208
Lines 24833 24766 -67
=======================================
+ Hits 19314 19579 +265
+ Misses 4539 4191 -348
- Partials 980 996 +16 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/combine_services_across_httproutes_expression_router
branch
from
December 4, 2024 08:16
40da52b
to
34393de
Compare
randmonkey
force-pushed
the
feat/combine_services_across_httproutes_expression_router
branch
2 times, most recently
from
December 4, 2024 12:35
2c6b80e
to
91a0f1f
Compare
randmonkey
force-pushed
the
feat/combine_services_across_httproutes_expression_router
branch
4 times, most recently
from
December 10, 2024 02:31
4a811e0
to
df6e670
Compare
pmalek
reviewed
Dec 10, 2024
randmonkey
force-pushed
the
feat/combine_services_across_httproutes_expression_router
branch
from
December 11, 2024 03:47
df6e670
to
c29f86c
Compare
randmonkey
force-pushed
the
feat/combine_services_across_httproutes_expression_router
branch
from
December 11, 2024 05:35
c29f86c
to
5eb89d1
Compare
pmalek
approved these changes
Dec 11, 2024
randmonkey
deleted the
feat/combine_services_across_httproutes_expression_router
branch
December 11, 2024 09:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Second part of #5801. Generate combined Kong services for rules sharing the same bakends when expression based routes are used.
Which issue this PR fixes:
Fixes #6727
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR