-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use kubernetes-telemetry package #3552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a make generate
commit to make the linter happy. Hopefully whatever CI license issue broke the other test earlier is gone now and this just auto-merges. If not, such is life.
Mmm, maybe not quite. Looks like we're stuck on actually using 0.6.1 because someone decided to start using new Go features? See failures in #3524. This otherwise looks fine, but I think we want to fix that first if we're going to start using the 0.6.1 CRDs. I suspect the 0.6.1 CRDs alone wouldn't actually cause issues, but I think we probably want the module also for consistency. Edit: looks like it also breaks conformance. I was wrong! |
Codecov ReportBase: 72.1% // Head: 72.0% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3552 +/- ##
=======================================
- Coverage 72.1% 72.0% -0.2%
=======================================
Files 127 128 +1
Lines 14771 14843 +72
=======================================
+ Hits 10657 10694 +37
- Misses 3437 3460 +23
- Partials 677 689 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It seems we needed an |
49eb91a
to
b11e4b8
Compare
1bbe015
to
20ca304
Compare
20ca304
to
62d05ba
Compare
What this PR does / why we need it:
This introduces usage of https://github.com/Kong/kubernetes-telemetry/ in KIC.
The existing code for anonymous reports was left as is in this PR but we can remove it if we decide that's the approach we'd like to take.
Reports have been checked to produce the same data (and more) as it can be observed in the added UTs.
Which issue this PR fixes:
Fixes #3541
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR