-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Define dedicated types for DBMode and RouterFlavor #5092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check also
test/internal/testenv/testenv.go
internal/dataplane/synchronizer_test.go:25
(and more)internal/clients/manager_test.go:228
internal/manager/utils/kongconfig/root_test.go
internal/dataplane/kong_client_test.go:684
I might miss something
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5092 +/- ##
=======================================
- Coverage 75.6% 75.5% -0.1%
=======================================
Files 167 168 +1
Lines 18906 18905 -1
=======================================
- Hits 14295 14288 -7
- Misses 3787 3791 +4
- Partials 824 826 +2
☔ View full report in Codecov by Sentry. |
- Moved DBMode and RouterFlavor enums from internal/util/dataplane to internal/dataplane/config. - Added a linter rule for internal/dataplane/config alias to be enforced to dpconf
e30abac
to
572545e
Compare
572545e
to
687e05e
Compare
c8309aa
to
c715829
Compare
c715829
to
f0a811c
Compare
What this PR does / why we need it:
Define dedicated types for DB mode and router flavor in
util/dataplane
for clarity and prevent definitions of constants everywhere.Which issue this PR fixes:
fixes #5013
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR