Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix e2e's artifact name #6768

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore(ci): fix e2e's artifact name #6768

merged 1 commit into from
Dec 4, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 4, 2024

What this PR does / why we need it:

Fix the issue that occurred in https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12156398089/job/33900270172#step:13:19.

The culprit is that when workflow fails, KONG_IMAGE_ARTIFACT is not set so there's a duplicated artifact name across tests against released and unreleased Kong.

@pmalek pmalek added the area/ci label Dec 4, 2024
@pmalek pmalek self-assigned this Dec 4, 2024
@pmalek pmalek requested a review from a team as a code owner December 4, 2024 09:50
@pmalek pmalek added ci/run-e2e Trigger e2e test run from PR and removed size/S labels Dec 4, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12157169845

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
programmer04
programmer04 previously approved these changes Dec 4, 2024
@pmalek pmalek force-pushed the fix-e2e-artifact-name branch from f643ea0 to 2f58cf8 Compare December 4, 2024 10:08
@pmalek pmalek added the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12157490093

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.7%. Comparing base (fbfdbeb) to head (6dd7bdb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6768     +/-   ##
=======================================
- Coverage   79.9%   77.7%   -2.3%     
=======================================
  Files        207     207             
  Lines      24588   24599     +11     
=======================================
- Hits       19665   19120    -545     
- Misses      3925    4500    +575     
+ Partials     998     979     -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

programmer04
programmer04 previously approved these changes Dec 4, 2024
@pmalek pmalek force-pushed the fix-e2e-artifact-name branch from 2f58cf8 to cf199b6 Compare December 4, 2024 10:37
@pmalek pmalek added the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12157983914

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
@pmalek pmalek force-pushed the fix-e2e-artifact-name branch from cf199b6 to 6dd7bdb Compare December 4, 2024 11:19
@pmalek
Copy link
Member Author

pmalek commented Dec 4, 2024

The artifact issue has been resolved.

https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12157983914/job/33905204636#step:13:3

image

TestDeployAllInOneDBLESS seem to fail but that's unrelated, I've created #6769 to track this.

@pmalek pmalek enabled auto-merge (squash) December 4, 2024 11:20
@pmalek pmalek merged commit 568a3f4 into main Dec 4, 2024
40 checks passed
@pmalek pmalek deleted the fix-e2e-artifact-name branch December 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants