3주차 미션 / 서버 2조 정윤아 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twkwon0417
reviewed
Oct 6, 2024
Comment on lines
+6
to
+10
| INDEX_HTML(Path.of("webapp/index.html")), | ||
| FORM_HTML(Path.of("webapp/user/form.html")), | ||
| LOGIN_HTML(Path.of("webapp/user/login.html")), | ||
| LOGIN_FAILED_HTML(Path.of("webapp/user/login_failed.html")), | ||
| STYLES_CSS(Path.of("css/styles.css")); |
Comment on lines
+6
to
+7
| HttpRequest httpRequest; | ||
| HttpResponse httpResponse; |
There was a problem hiding this comment.
Controller의 request, response를 member 변수로 선언하신 이유가 있나요?
Comment on lines
+13
to
+18
| private String startLine; | ||
| private String method; | ||
| private String url; | ||
| private String version; | ||
| private String header; | ||
| private String body; |
There was a problem hiding this comment.
바뀌지 않아야 하는 항목들이니까 final keyword를 붙이면 좋을 것 같습니다.
There was a problem hiding this comment.
HttpRequest가 너무 많은 책임을 가지고 있는거 같습니다.
HttpRequest의 멤버 변수로 startline, body, header 객체들을 구성하고, 각자 관리하면 좋을 거 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
쿠키 확인, 테스트 코드 작성 미완성입니다..! 추가 진행하겠습니다.