3주차 미션 / 서버 2조 정상현 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twkwon0417
reviewed
Oct 5, 2024
| path = "/index.html"; | ||
| } | ||
|
|
||
| if(HttpMethod.GET.equals(method)) { |
There was a problem hiding this comment.
이렇게 비교하면 매번 false가 뜰꺼에요. Enum이 어떻게 저장, 비교 되는지 알아보시면 좋을거 같습니다.
| if(isLogined) { | ||
| File userListFile = new File(Web_Folder + "/user/list.html"); | ||
|
|
||
| if (!userListFile.exists()) { |
There was a problem hiding this comment.
파일이 존재하는 지 검사하는 이유가 있으신가요?
사용자 입력에 대한 검증이 아니라
File userListFile = new File(Web_Folder + "/user/list.html"); 을 따로 검증해준 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
저의 구현력의 민낯을 볼 수 있었던 주차였던 것 같습니다.
거의 모든 내용이 처음이었고, 최대한 이해하려했으나 리팩토링은 enum까지 밖에 수행하지 못했습니다.
PR이후에도 계속 보면서 내용 습득 할 수 있도록 노력하겠습니다.