2주차 미션 / 서버 3조 김윤서 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word in Row class
JangIkhwan
reviewed
Sep 28, 2024
| public class LadderGameFactory { | ||
|
|
||
| public static LadderGame createRandomLadderGame(GreaterThanOne numberOfRow, GreaterThanOne numberOfPerson) { | ||
| LadderCreatorInterface ladderCreator = new LadderAutoCreator(numberOfRow, numberOfPerson); |
There was a problem hiding this comment.
팩토리 잘 만드신 것 같아요. game 객체를 만드는 코드를 한 곳에서 관리할 수 있으니 수정이 편해지겠네요!
| rows[i] = new Row(numberOfPerson); | ||
| } | ||
|
|
||
| createRandomLines(numberOfPerson); |
| StringBuilder ladderBuilder = new StringBuilder(); | ||
|
|
||
| for (int i = 0; i < rows.length; i++) { | ||
| ladderBuilder.append(rows[i].printRow(position, i == currentRow)); |
There was a problem hiding this comment.
음 제어 변수로 별을 찍을지 결정하는 것 괜찮은 것 같은데, 이런 제어 결합도는 혼란을 일으킬 수 있으니 주의해서 사용해야할 것 같습니다.
|
|
||
| for (int i = 0; i < nodes.length; i++) { | ||
| rowBuilder.append(getNodeIndex(i)) | ||
| .append((isCurrentRow && i == position.getPosition()) ? "*" : "") |
There was a problem hiding this comment.
position 객체의 내부 값이 getter로 노출되네요. 메소드 내부에서 값 비교를 하면 캡슐화를 이룰 수 있지 않을까요?
| return IsLineAtPosition; | ||
| } | ||
|
|
||
| private String getNodeIndex(int index) { |
There was a problem hiding this comment.
Node에 Direction이 있고 어떤 값을 가지는지 알아야 해서 다른 객체와의 결합도가 늘어난 것 같아요. 캡슐화를 적용해볼까요?
Comment on lines
+30
to
+39
| while (linesDrawn < numberOfLines) { | ||
| int randomRow = random.nextInt(rows.length); | ||
| int randomCol = random.nextInt(numberOfPerson.getNumber() - 1); | ||
|
|
||
| Position position = Position.from(randomCol); | ||
|
|
||
| if (rows[randomRow].canDrawLineAt(position.getPosition())) { | ||
| rows[randomRow].drawLine(position); | ||
| linesDrawn++; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.