2주차 미션 / 서버 1조 김지현 #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmw10693
reviewed
Sep 28, 2024
|
|
||
| private final int number; | ||
|
|
||
| public GreaterThanOne(int number) { |
There was a problem hiding this comment.
정적 팩터리 메서드인 from()으로 객체를 반환하니 생성자는 private으로 설정해도 좋아보이네요!
| @@ -0,0 +1,29 @@ | |||
| package ladder; | |||
|
|
|||
| public class GreaterThanOne { | |||
| private final Row[] rows; | ||
|
|
||
| public LadderCreator(GreaterThanOne numberOfRow, GreaterThanOne numberOfPerson) { | ||
| rows = new Row[numberOfRow.getNumber()]; |
There was a problem hiding this comment.
로우를 불러 올때 생성자보다 따로 매개변수를 가진 정적 팩터리 메서드를 생성하여 불러오는게 좋겠네요!
| class LadderGameTest { | ||
|
|
||
| @Test | ||
| void 사다리_생성_확인() { |
There was a problem hiding this comment.
@DisplayName 어노테이션을 이용하여 더 테스트를 명확하게 설명 가능해요!
| GreaterThanOne numberOfPerson = GreaterThanOne.from(5); | ||
|
|
||
| //when | ||
| LadderCreator ladderCreator = new LadderCreator(numberOfRow, numberOfPerson); |
There was a problem hiding this comment.
매개변수가 많을때는 생성자보다 빌더 패턴을 고려해보는것도 좋겠네요!
| LadderCreator ladderCreator = new LadderCreator(numberOfRow, numberOfPerson); | ||
|
|
||
| //then | ||
| assertThat(ladderCreator).isNotNull(); |
There was a problem hiding this comment.
사다리 생성을 확인할때 notnull임을 검증하는것도 좋으나, row가 3이고 사람이 5인거를 검증하는게 더 명확해 보입니다!
| void 사다리_사람_예외_처리_확인() { | ||
| //when | ||
| GreaterThanOne numberOfPerson = GreaterThanOne.from(3); | ||
| LadderCreator ladderCreator = new LadderCreator(GreaterThanOne.from(2), numberOfPerson); |
There was a problem hiding this comment.
New ladderCreator() 보다는 메서드 체이닝 방식으로 생성자를 만들수 있는 빌더 패턴을 고려해보세요!
| LadderCreator ladderCreator = new LadderCreator(row, numberOfPerson); | ||
| LadderGame ladderGame = new LadderGame(ladderCreator); | ||
|
|
||
| ladderCreator.drawLine(Position.from(0),Position.from(0)); |
There was a problem hiding this comment.
Drawline이 3개의 메서드로 로직이 겹치는것 같아요 private 메서드로 빼서 공통 로직을 구현해보는게 어떨까요?
| //ladderCreator.drawLine(Position.from(1),Position.from(2)); | ||
| ladderCreator.drawLine(Position.from(2),Position.from(1)); | ||
| ladderCreator.drawLine(Position.from(3),Position.from(0)); | ||
| ladderRunner.run(Position.from(1)); |
| void 한_칸_사다리_이동() { | ||
| //when | ||
| GreaterThanOne numberOfPerson = GreaterThanOne.from(2); | ||
| Row row = new Row(numberOfPerson); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
사다리 출력 기능만 구현했습니다..추가 구현 후 다시 pr보내겠습니다