Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Krypton Toolkit 60.22.2.32 - ButtonSpec Images #623

Closed
MattH-Work opened this issue Feb 1, 2022 · 12 comments
Closed

[Bug]: Krypton Toolkit 60.22.2.32 - ButtonSpec Images #623

MattH-Work opened this issue Feb 1, 2022 · 12 comments
Labels
bug Something isn't working completed This issue has been completed. fixed This issue has been fixed.
Milestone

Comments

@MattH-Work
Copy link

Squished images in Buttonspecs
Button height has changed, therefore image is 'stretching' to suit

6.2111.312 (Good)
image
image

60.22.2.32 (Bad)
image
image

@MattH-Work MattH-Work added the bug Something isn't working label Feb 1, 2022
@MattH-Work
Copy link
Author

In Comboxes, the drop down 'button' has been centred (notice the slight reduction in white space under the drop down)
But this then changes the height of the control, which intern changes the height of the Buttonspec & image, and also changes the image due to the vertical compression

6.2111.312
image

60.22.2.32
image

@MattH-Work
Copy link
Author

MattH-Work commented Feb 1, 2022

Tying in with issue #615, the height of my Comboboxes have now reduced to 20 pixels, compared to the original 22

image
image

Not much, but when there is a mix of heights bewtweeen all the different controls on my form (99% of which are Krypton.Toolkit) the OCD is firing left right & centre, and the text is also being clipped
image

@Smurf-IV
Copy link
Member

Smurf-IV commented Feb 6, 2022

Tying in with issue #615, the height of my Comboboxes have now reduced to 20 pixels, compared to the original 22

Bit confused... #615 has had nothing done for it yet, so what reduced the size down to 20 ?

@Smurf-IV Smurf-IV added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Feb 6, 2022
@Smurf-IV
Copy link
Member

Smurf-IV commented Feb 6, 2022

In Comboxes, the drop down 'button' has been centred (notice the slight reduction in white space under the drop down) But this then changes the height of the control, which intern changes the height of the Buttonspec & image, and also changes the image due to the vertical compression

@MattH-Work
re: vertical compression: This may be sorted by the changes made to sort out that artefact in #603.
Please use a build after todays build date and re-test
Also, can you supply an example app that shows your rounding, and images in situ please ?

@MattH-Work
Copy link
Author

MattH-Work commented Feb 7, 2022

image
Two combo boxes, one with 0 (-1) rounding radius & one with a radius of 5
Two panels, showing the icons as expected. Magnifying glass is 17x17, eye is 16x16 (actuall 'visable' pixels are 16x12)
As you can see, the vertical height is compressed by 2 pixels, a 'slight' change for the magnifying glass but drops the vertical height too much for the eye
ButtonSpecTest.zip

@MattH-Work
Copy link
Author

MattH-Work commented Feb 7, 2022

image

This is the same form updated to Krypton.Toolkit.Nightly 60.22.2.38-alpha (seems 'something' has reverted back to a previous setting)

The icons now display correctly, BUT...
a) The Buttonspec position have reset to 'Far' for both (this can be fixed by me, so just an observation)
b) Image Style has reset to 'Inherit' for both panels (were set to 'Center - Middle', again, this can be fixed by me, so just an observation)
c) The 'centred' drop down button now has more pixels below than above (a price I'm prepaped to pay for the improved icon display)
d) The overall height of the Comboboxes has increased (21 upto 23 & 25 upto 27). Is there a border/margin around the ButtonSpec / ButtonSpec image that can be tweaked rather than the overall height of the combo, I rather liked to clean 25 height!

Edit. The above observations actually just match the Buttonspec behaviour prior to the problem appearing in the February stable build, so it's actually just back to how it always was, so there's an agument to say nothing has changed, just a regression fixed.

@Smurf-IV
Copy link
Member

Smurf-IV commented Feb 7, 2022

This is the same form updated to Krypton.Toolkit.Nightly 60.22.2.38-alpha (seems 'something' has reverted back to a previous setting)

Yes, that would be the fix for #603.

The icons now display correctly, BUT...
a) The Buttonspec position have reset to 'Far' for both (this can be fixed by me, so just an observation)

Not sure what has happened there, as that will be a designer thing, and should have taken the value that you set.

b) Image Style has reset to 'Inherit' for both panels (were set to 'Center - Middle', again, this can be fixed by me, so just an observation)

Not sure what has happened there, as that will be a designer thing, and should have taken the value that you set.

c) The 'centred' drop down button now has more pixels below than above (a price I'm prepaped to pay for the improved icon display)

The min height has had to be restored to the original calc, and doe snot "Know" about the actual size until after the "Prefered size" has been calculated. Youmight be able to fix this by augmenting the "GetPreferredSize" API, and setting it to a hard coded value ( - just an idea, not sure how to accomplish without trying it, which I cannot at the moment!)

d) The overall height of the Comboboxes has increased (21 upto 23 & 25 upto 27). Is there a border/margin around the ButtonSpec / ButtonSpec image that can be tweaked rather than the overall height of the combo, I rather liked to clean 25 height!

See anser to c)

Edit. The above observations actually just match the Buttonspec behaviour prior to the problem appearing in the February stable build, so it's actually just back to how it always was, so there's an agument to say nothing has changed, just a regression fixed.

Not quite, the icons now scale to whatever windows screen preference scaling the user has set when the application starts, please see the images during the investigation of #603

@Smurf-IV
Copy link
Member

Smurf-IV commented Feb 7, 2022

@MattH-Work Can this be closed now ?

@MattH-Work
Copy link
Author

Yes, please close this.
I am happy to wait until the nightly build filters down to Stable (March / April?)

@Smurf-IV
Copy link
Member

Smurf-IV commented Feb 7, 2022

Yes, please close this. I am happy to wait until the nightly build filters down to Stable (March / April?)

I think these recent changes are targeted for April

@Smurf-IV Smurf-IV closed this as completed Feb 7, 2022
@PWagner1 PWagner1 added this to the April 2022 milestone Feb 7, 2022
@PWagner1 PWagner1 added completed This issue has been completed. fixed This issue has been fixed. and removed awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels Feb 7, 2022
@MattH-Work
Copy link
Author

Using 65.22.6.152 this issue has re-appeared

This 'eyeball' (from a combobox buttonspec)
image

Should look like this 'eyeball' (from a command button)
image

Same vertical compression on all ButtonSpecs images
image

@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 9, 2022

@MattH-Work Please create a new Linked bug, and state what OS and TFM you are using (I have a feeling that .net6 introduced a bigger margin for buttons, etc!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed This issue has been completed. fixed This issue has been fixed.
Projects
None yet
Development

No branches or pull requests

3 participants