Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support external secret type #38

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 3, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

support external secret type

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the enhancement New feature or request label Dec 3, 2023
@adohe adohe requested a review from elliotxx as a code owner December 3, 2023 09:51
@adohe adohe force-pushed the add_external_secret branch from 67898dd to a7f8eb9 Compare December 3, 2023 13:42
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit b00d055 into KusionStack:main Dec 5, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants