fix: skip resources not found for json patch (#1294)

KusionStack · Sep 23, 2024 · 67d4ab5 · 67d4ab5
1 parent bccd483
commit 67d4ab5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/modules/generators/app_configurations_generator.go b/pkg/modules/generators/app_configurations_generator.go
@@ -217,7 +217,8 @@ func JSONPatch(resources v1.Resources, patcher *v1.Patcher) error {
 		for id, jsonPatcher := range patcher.JSONPatchers {
 			res, ok := resIndex[id]
 			if !ok {
-				return fmt.Errorf("target patch resource %s not found", id)
+				log.Warnf("target patch resource %s not found, skipped", id)
+				continue
 			}
 
 			target := jsonutil.Marshal2String(res.Attributes)

diff --git a/pkg/modules/generators/app_configurations_generator_test.go b/pkg/modules/generators/app_configurations_generator_test.go
@@ -499,7 +499,7 @@ func TestJsonPatch(t *testing.T) {
 				"notfound": {Type: v1.MergePatch, Payload: []byte(`{"key": "value"}`)},
 			},
 		})
-		assert.Error(t, err)
+		assert.Nil(t, err)
 	})
 
 	t.Run("MergePatch", func(t *testing.T) {