-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize kusion apply with by default watching #1139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-hm19
force-pushed
the
refine-apply-watch
branch
from
May 30, 2024 02:31
2231fd3
to
75a719d
Compare
liu-hm19
added
the
kind/feature
Categorizes issue or PR as related to a new feature
label
May 30, 2024
Pull Request Test Coverage Report for Build 9363437442Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
liu-hm19
force-pushed
the
refine-apply-watch
branch
from
May 30, 2024 11:40
54fa6f5
to
bc0147d
Compare
liu-hm19
force-pushed
the
refine-apply-watch
branch
from
May 30, 2024 11:42
bc0147d
to
32ce5ed
Compare
liu-hm19
changed the title
feat: refine kusion apply with watch
feat: optimize kusion apply with by default watching
May 30, 2024
SparkYuan
reviewed
May 30, 2024
SparkYuan
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR refines the
kusion apply
cmd with augmented watch ability and a better terminal display.kusion apply
now will by default check whether the resource is reconciled while applying and support setting thetimeout
flag.Which issue(s) this PR fixes:
Fixes #1115 and #1116
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: