Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trace for module and split module logs #1332

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

gshilei
Copy link
Contributor

@gshilei gshilei commented Nov 27, 2024

What type of PR is this?

feat: add trace for module and split module logs

What this PR does / why we need it:

Which issue(s) this PR fixes:

#1304

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 12064118352

Details

  • 3 of 7 (42.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 48.716%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/plugin.go 0 4 0.0%
Totals Coverage Status
Change from base Build 11834118525: 0.003%
Covered Lines: 10564
Relevant Lines: 21685

💛 - Coveralls

pkg/modules/plugin.go Outdated Show resolved Hide resolved
pkg/modules/generators/app_configurations_generator.go Outdated Show resolved Hide resolved
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit c1367bd into KusionStack:main Nov 28, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@ffforest ffforest added this to the v0.14.0 milestone Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants