feat: ✨ liq-src: kyber-pmm #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thanhpp <[email protected]>
thanhpp
requested review from
piavgh,
it4rb,
NgoKimPhu and
lehainam-dev
as code owners
Test coverage changes:
|
Signed-off-by: thanhpp <[email protected]>
…s://github.com/KyberNetwork/kyberswap-dex-lib into TRD-759-kyberswap-dex-lib-create-kyber-pmm-v-2
lehainam-dev
reviewed
Dec 4, 2024
| "github.com/KyberNetwork/logger" | ||
| "github.com/dgraph-io/ristretto" | ||
|
|
||
| kyberpmm "github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/kyber-pmm" |
There was a problem hiding this comment.
"github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/kyber-pmm"
lehainam-dev
reviewed
Dec 4, 2024
| @@ -0,0 +1,21 @@ | |||
| package client | |||
There was a problem hiding this comment.
Minor: I don't see any major changes in client pkg. Can we re-use the client pkg in source/kyber-pmm?
If eventually, we remove the source/kyber-pmm, then it's ok to add client here.
There was a problem hiding this comment.
hmm, i think we should move to a new pkg and remove the old one
There was a problem hiding this comment.
hmm, i think we should move to a new pkg and remove the old one
lehainam-dev
reviewed
Dec 4, 2024
| inventoryLimitIn = limit.GetLimit(param.TokenAmountIn.Token) | ||
| ) | ||
| if param.TokenAmountIn.Amount.Cmp(inventoryLimitIn) > 0 { | ||
| return nil, errors.New("not enough inventory in") |
There was a problem hiding this comment.
We can move the error into error.go (same as CalcAmountIn PR)
lehainam-dev
reviewed
Dec 4, 2024
Comment on lines
72
to
76
| if slices.ContainsFunc(staticExtra.QuoteTokenAddresses, func(s string) bool { | ||
| return strings.EqualFold(s, entityPool.Tokens[i].Address) | ||
| }) { | ||
| quoteTokens = append(quoteTokens, *entityPool.Tokens[i]) | ||
| } |
There was a problem hiding this comment.
Minor: Can we create a map first to check if the token exists?
lehainam-dev
reviewed
Dec 4, 2024
| timestamp: entityPool.Timestamp, | ||
| }, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to write custom CanSwapFrom(baseToken) and CanSwapTo(quoteToken) functions here.
Signed-off-by: thanhpp <[email protected]>
Signed-off-by: thanhpp <[email protected]>
lehainam-dev
reviewed
Dec 6, 2024
| return result | ||
| } | ||
|
|
||
| return []string{p.baseToken.Address} |
There was a problem hiding this comment.
You should check if the input address is in quoteTokens, then return the baseToken, otherwise, this should return nil.
Signed-off-by: thanhpp <[email protected]>
…-lib-create-kyber-pmm-v-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did we need it?
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):